Re: [PATCH] drivers: thermal: tsens: Fix null pointer dereference

From: Konrad Dybcio
Date: Tue Apr 09 2024 - 05:52:23 EST




On 4/5/24 11:07, Aleksandr Mishin wrote:
compute_intercept_slope() is called from calibrate_8960() (in tsens-8960.c)
as compute_intercept_slope(priv, p1, NULL, ONE_PT_CALIB) which lead to null
pointer dereference (if DEBUG or DYNAMIC_DEBUG set).
Fix this bug by adding null pointer check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: dfc1193d4dbd ("thermal/drivers/tsens: Replace custom 8960 apis with generic apis")
Signed-off-by: Aleksandr Mishin <amishin@xxxxxxxxxx>
---

Maybe we can replace p2[i] with p2 ? p2[i] : 0

Konrad