Re: [PATCH v3 2/2] usb: typec: ucsi: Implement ChromeOS UCSI driver

From: Tzung-Bi Shih
Date: Tue Apr 09 2024 - 06:40:05 EST


On Mon, Apr 08, 2024 at 07:47:35PM -0700, Pavan Holla wrote:
> On Mon, Apr 8, 2024 at 1:13 AM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> >
> > How this driver get probed? From drivers/mfd/cros_ec_dev.c? If so, there is
> > no "cros-ec-ucsi" in the MFD driver yet.
>
> Yes, this should get probed from drivers/mfd/cros_ec_dev.c. However, the
> corresponding change in the EC is still under review. I was planning to send
> it out once the EC change lands. Please let me know if you think that this
> review should wait until then.

I see. The mfd patch is independent and can be sent later.

I was asking because the patch (and the series) don't reflect the message:
"This driver will be loaded if the ChromeOS EC implements a PPM."

However, include/linux/platform_data/cros_ec_commands.h (the previous patch in
the series) usually follows include/ec_commands.h[1]. We should wait until
the corresponding EC patches land.

[1]: https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/ec_commands.h