Re: [PATCH v4 2/3] mmc: block: register RPMB partition with the RPMB subsystem

From: Jens Wiklander
Date: Tue Apr 09 2024 - 08:01:28 EST


Hi Linus,

On Mon, Apr 8, 2024 at 11:07 AM Linus Walleij <linus.walleij@linaroorg> wrote:
>
> Hi Jens,
>
> On Fri, Apr 5, 2024 at 1:53 PM Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
>
> > +/**
> > + * struct rpmb_frame - rpmb frame as defined by specs
>
> As Tomas said maybe we can write the name of the spec or the number or
> something so users can find it?
>
> I would also write explicitly "the stuff bytes and big-endian properties are
> modeled to fit to the spec".

That makes sense, I'll add it.

Thanks,
Jens

>
> Yours,
> Linus Walleij