Re: [PATCH] tty: Convert from tasklet to BH workqueue

From: Allen
Date: Tue Apr 09 2024 - 11:49:17 EST


> > The only generic interface to execute asynchronously in the BH context is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workqueue
> > behaves similarly to regular workqueues except that the queued work items
> > are executed in the BH context.
> >
> > This patch converts drivers/tty/* from tasklet to BH workqueue.
>
> Quickly looking into the changes, could you also elaborate why not to
> convert most (all?) of them to (non-BH) wq? Or threaded IRQs. Much of
> the code comes from the pre-WQ era.
>

You are right. The idea I had was to convert every instance of tasklet to
bh workqueues in the kernel. I will send out a v2, which will use
threaded IRQ's.

Thanks.