Re: [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1 GMAC

[Geert Uytterhoeven]

Hi Romain,

On Tue, Apr 9, 2024 at 11:21 AM Romain Gantois
<romain.gantois@xxxxxxxxxxx> wrote:
> From: Clément Léger <clement.leger@xxxxxxxxxxx>
>
> Add support for the Renesas RZ/N1 GMAC. This support can make use of a
> custom RZ/N1 PCS which is fetched by parsing the pcs-handle device tree
> property.
>
> Signed-off-by: "Clément Léger" <clement.leger@xxxxxxxxxxx>
> Co-developed-by: Romain Gantois <romain.gantois@xxxxxxxxxxx>
> Signed-off-by: Romain Gantois <romain.gantois@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -142,6 +142,18 @@ config DWMAC_ROCKCHIP
>           This selects the Rockchip RK3288 SoC glue layer support for
>           the stmmac device driver.
>
> +config DWMAC_RZN1
> +       tristate "Renesas RZ/N1 dwmac support"
> +       default ARCH_RZN1

Why default to enabled?

> +       depends on OF && (ARCH_RZN1 || COMPILE_TEST)
> +       select PCS_RZN1_MIIC
> +       help
> +         Support for Ethernet controller on Renesas RZ/N1 SoC family.
> +
> +         This selects the Renesas RZ/N1 SoC glue layer support for
> +         the stmmac device driver. This support can make use of a custom MII
> +         converter PCS device.
> +
>  config DWMAC_SOCFPGA
>         tristate "SOCFPGA dwmac support"
>         default ARCH_INTEL_SOCFPGA

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds