Re: [PATCH] vdso: Fix powerpc build U64_MAX undeclared error

From: John Stultz
Date: Tue Apr 09 2024 - 13:07:54 EST


On Mon, Apr 8, 2024 at 11:27 PM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>
> U64_MAX is not in include/vdso/limits.h, although that isn't noticed on x86
> because x86 includes include/linux/limits.h indirectly. However powerpc
> is more selective, resulting in the following build error:
>
> In file included from <command-line>:
> lib/vdso/gettimeofday.c: In function 'vdso_calc_ns':
> lib/vdso/gettimeofday.c:11:33: error: 'U64_MAX' undeclared
> 11 | # define VDSO_DELTA_MASK(vd) U64_MAX
> | ^~~~~~~
>
> Use ULLONG_MAX instead which will work just as well and is in
> include/vdso/limits.h.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/20240409124905.6816db37@xxxxxxxxx.orgau/
> Fixes: c8e3a8b6f2e6 ("vdso: Consolidate vdso_calc_delta()")
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Acked-by: John Stultz <jstultz@xxxxxxxxxx>