Re: [PATCH v3 05/19] media: venus: pm_helpers: Kill dead code

[Konrad Dybcio]

On 4/5/24 09:49, Dikshita Agarwal wrote:
> On 3/27/2024 11:38 PM, Konrad Dybcio wrote:
> > A situation like:
> >
> > if (!foo)
> > 	goto bar;
> >
> > for (i = 0; i < foo; i++)
> > 	...1...
> >
> > bar:
> > 	...2...
> >
> > is totally identical to:
> >
> > for (i = 0; i < 0; i++) // === if (0)
> > 	...1...
> >
> > ...2...
> >
> > Get rid of such boilerplate.
> >
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > ---
> >   drivers/media/platform/qcom/venus/pm_helpers.c | 10 ----------
> >   1 file changed, 10 deletions(-)
> >
> > diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
> > index ef4b0f0da36f..730c4b593cec 100644
> > --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> > +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> > @@ -878,14 +878,10 @@ static int vcodec_domains_get(struct venus_core *core)
> >   		.pd_flags = PD_FLAG_NO_DEV_LINK,
> >   	};
> >   
> > -	if (!res->vcodec_pmdomains_num)
> > -		goto skip_pmdomains;
> > -
> this condition should still be there to skip calling
> dev_pm_domain_attach_list if vcodec_pmdomains_num is 0.

That should be totally fine, within that function there's this bit

if (num_pds <= 0)
	return 0;

which bails out gracefully

Konrad