Re: [PATCH v2 1/1] ASoC: dt-bindings: fsl-esai: Convert fsl,esai.txt to yaml
From: Frank Li
Date: Tue Apr 09 2024 - 14:59:28 EST
On Tue, Apr 09, 2024 at 12:26:52PM -0500, Rob Herring wrote:
> On Fri, Mar 22, 2024 at 9:54 AM Frank Li <Frank.Li@xxxxxxx> wrote:
> >
> > Convert fsl,esai.txt to yaml. So DTB_CHECK tools can verify dts file about
> > esai part.
> >
> > clock-names 'spba' is optional according to description. So minItems of
> > clocks and clock-names is 3.
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> >
> > Notes:
> > Change from v1 to v2
> > - alphabetical order compatible string according to rob's suggestion
> > - clock description move under 'clock' according to kryszof's suggestion
> > - fix descritpion indent according to rob's suggestion
> >
> > Pass dt_binding check
> > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,esai.yaml
> > DTEX Documentation/devicetree/bindings/sound/fsl,esai.example.dts
> > LINT Documentation/devicetree/bindings
> > CHKDT Documentation/devicetree/bindings/processed-schema.json
> > SCHEMA Documentation/devicetree/bindings/processed-schema.json
> > DTC_CHK Documentation/devicetree/bindings/sound/fsl,esai.example.dtb
>
> Did you run dtbs_check too? Probably not arm32 at least (first number
> is number of warnings):
>
> 218 esai@2024000: clocks: [[2, 208], [2, 209], [2, 118], [2,
> 208], [2, 156]] is too long
> 218 esai@2024000: clock-names:3: 'spba' was expected
> 218 esai@2024000: clock-names:2: 'fsys' was expected
> 218 esai@2024000: clock-names:1: 'extal' was expected
> 218 esai@2024000: clock-names: ['core', 'mem', 'extal', 'fsys',
> 'spba'] is too long
Yes, I run dtb_check for one platform. Which dtb report this warning?
Frank
>
> Conversions can leave warnings, but any you think should be fixed in
> the binding should be fixed in the conversion.
>
> Rob