Re: [PATCH v2] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate 5% safety margin

From: Francesco Dolcini
Date: Tue Apr 09 2024 - 15:52:49 EST


On Tue, Apr 09, 2024 at 02:37:15PM -0500, Judith Mendez wrote:
> Hi all,
>
> On 4/6/24 8:01 AM, Guenter Roeck wrote:
> > On Thu, Apr 04, 2024 at 10:33:19AM -0500, Judith Mendez wrote:
> > > On AM62x, the watchdog is pet before the valid window
> > > is open. Fix min_hw_heartbeat and accommodate a 5% safety
> > > margin with the exception of open window size < 10%,
> > > which shall use <5% due to the smaller open window size.
>
> Please do not merge this patch, I will add an additional
> patch removing the hack in this driver.

Is the patch buggy, or you are just talking about an additional clean-up?
If it is an additional patch and this code is fine, why holding it back?

Thanks,
Francesco