Re: [PATCH] selftests: kselftest_harness: Print empty string, not empty fmt on PASS/FAIL

From: Sean Christopherson
Date: Tue Apr 09 2024 - 20:14:31 EST


On Tue, Apr 09, 2024, Jakub Kicinski wrote:
> On Tue, 9 Apr 2024 15:42:56 -0700 Sean Christopherson wrote:
> > - ksft_test_result_code(t->exit_code, test_name,
> > - diagnostic ? "%s" : "", diagnostic);
> > + ksft_test_result_code(t->exit_code, test_name, "%s", diagnostic);
>
> Have you tested that to make sure it doesn't change the output?
>
> .. warning: ^^ leading question ;)

Heh, I was *this* close to adding a blurb saying this was probably only compile
tested.