Re: [PATCH v10 2/4] dt-bindings: stm32: update DT bingding for stm32mp25

From: Gabriel FERNANDEZ
Date: Wed Apr 10 2024 - 03:52:57 EST



On 4/10/24 09:06, Krzysztof Kozlowski wrote:
On 09/04/2024 19:12, gabriel.fernandez@xxxxxxxxxxx wrote:
From: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>

A nit, subject: drop second/last, redundant "DT bindings". (plus a
typo...) The "dt-bindings" prefix is already stating that these are
bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Subject: Everything is an update. Be specific.
ok

RCC driver uses '.index' to define all parent clocks instead '.names'
because the use of a name to define a parent clock is prohibited.
This is ABI change, but the RCC driver has not yet merged, unlike all
others drivers besides Linux.

Fixes: b5be49db3d47 ("dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform")
Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
---

Changes in v10:
- cosmetic change (add change blank line)
- rename USB2 into USBH to be compliant with last Reference Manuel

Changes in v9:
- Update DT binding documentation according S.Boyd remarks on RCC driver:
Don't use '.name' to define a parent but use '.index'
Then:
- remove 'clock-names' property
- Add description of all parent clocks used in RCC driver

v9 was Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Please avoid putting full acks somewhere in the changelog. You confuse
people's filters and maybe tooling as well. "v9 was Acked-by Conor
Dooley", so a proper sentence, not "fake" ack, would work for everyone.


With fixes in the subject:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Thank's

Best regards

Gabriel


Best regards,
Krzysztof