Re: [PATCH v3 1/2] dt-bindings: riscv: add Milk-V Duo S board compatibles

[Michael Opdenacker]

Hi Inochi

Thanks for the reviews!

On 4/10/24 at 09:19, Inochi Amaoto wrote:
> On Wed, Apr 10, 2024 at 08:22:53AM +0200, michael.opdenacker@xxxxxxxxxxx wrote:
> > From: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxx>
> >
> > Document the compatible strings for the Milk-V Duo S board[1] which uses
> > the SOPHGO SG2000 SoC, compatible with the SOPHGO CV1800B SoC[2].
> >
> > Link: https://milkv.io/duo-s [1]
> > Link: https://en.sophgo.com/product/introduce/cv180xB.html [2]
> >
> > Signed-off-by: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > index 9bc813dad098..1837bc550056 100644
> > --- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > @@ -21,6 +21,7 @@ properties:
> >         - items:
> >             - enum:
> >                 - milkv,duo
> > +              - milkv,duos
> >             - const: sophgo,cv1800b
> Why not adding sg2000 property? They are different series.
> IIRC, it at least a cv1813h not cv1800b. I suggest checking
> the vendor SDK to get the right board compatibles.

Here's what there was in the vendor provided DTB, if I noted it correctly:
compatible = "cvitek,cv181x";

Cheers
Michael

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com