Re: [PATCH v2 1/2] dt-bindings: mfd: Add ROHM BD71879

[Matti Vaittinen]

On 4/4/24 22:54, Andreas Kemnade wrote:
> As this chip was seen in several devices in the wild, add it.
>
> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> Suggested-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> ---
>   .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml         | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> index 0b62f854bf6b..07f99738fcf6 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> @@ -17,7 +17,12 @@ description: |
>   
>   properties:
>     compatible:
> -    const: rohm,bd71828
> +    oneOf:
> +      - const: rohm,bd71828
> +
> +      - items:
> +          - const: rohm,bd71879
> +          - const: rohm,bd71828
>   
>     reg:
>       description:

Am I correct, this reads as:

Either
	compatible = rohm,bd71828
or
	compatible = rohm,bd71879, rohm,bd71828

but not compatible = rohm,bd71879?

If so, this looks ok to me. :)
	

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~