Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: btnxpuart: Add firmware-name property

[Neeraj Sanjay Kale]

Hi Krzysztof,

Thank you for the review. I have made the changes you requested and sent out the v3 patch.

Thanks,
Neeraj

> 
> On 08/04/2024 15:22, Neeraj Sanjay Kale wrote:
> > This adds a new optional device tree property called firware-name.
> >
> > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx>
> 
> BTW, there is no such device as btnxpuart. Bindings are for hardware.
> With corrected subject:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> 
> > ---
> > v2: Add maxItems, simplify description, remove "nxp/". (Krzysztof)
> > ---
> >  .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > index f01a3988538c..6774cc4d6a9e 100644
> > ---
> > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.y
> > +++ aml
> > @@ -31,6 +31,11 @@ properties:
> >        This property depends on the module vendor's
> >        configuration.
> >
> > +  firmware-name:
> > +    maxItems: 1
> > +    description:
> > +      Specify firmware file name.
> 
> Drop description, redundant. You did not say anything different than property
> is saying already.