Re: [PATCH net-next v11 01/13] net: phy: Introduce ethernet link topology representation

From: Maxime Chevallier
Date: Wed Apr 10 2024 - 04:16:50 EST


Hello Nathan,

On Tue, 9 Apr 2024 13:15:53 -0700
Nathan Chancellor <nathan@xxxxxxxxxx> wrote:

> Hi Maxime,
>
> On Thu, Apr 04, 2024 at 11:29:51AM +0200, Maxime Chevallier wrote:

[...]

> I bisected a crash that I see on one of my test devices to this change
> in -next as commit 6916e461e793 ("net: phy: Introduce ethernet link
> topology representation"). Here is the stack trace passed through
> scripts/decode_stacktrace.sh:

[...]

> [ 5.626535] ? phy_link_topo_add_phy (drivers/net/phy/phy_link_topology.c:46) libphy
> [ 5.627954] ? _raw_spin_lock (arch/x86/include/asm/atomic.h:115 (discriminator 4) include/linux/atomic/atomic-arch-fallback.h:2170 (discriminator 4) include/linux/atomic/atomic-instrumented.h:1302 (discriminator 4) include/asm-generic/qspinlock.h:111 (discriminator 4) include/linux/spinlock.h:187 (discriminator 4) include/linux/spinlock_api_smp.h:134 (discriminator 4) kernel/locking/spinlock.c:154 (discriminator 4))
> [ 5.627963] phy_link_topo_add_phy (include/linux/xarray.h:977 drivers/net/phy/phy_link_topology.c:80) libphy
> [ 5.629462] phy_attach_direct (drivers/net/phy/phy_device.c:1516) libphy
> [ 5.629504] phylink_connect_phy (drivers/net/phy/phylink.c:1983) phylink
> [ 5.631030] ax88772_bind (drivers/net/usb/asix_devices.c:710 drivers/net/usb/asix_devices.c:919) asix
> [ 5.631049] usbnet_probe (drivers/net/usb/usbnet.c:1745) usbnet

I've run some tests on an arm64 board using an USB to Ethernet adapter
that uses the same driver (It also goes through ax88772_bind() ) but I
don't reproduce the error.

> If there is any additional information I can provide or patches I can
> test, I am more than happy to do so.

The next step for me would be to try on an x86_64 box to get closer to
the config you used, however could you give me the .config that was used
when the bug was triggered ? I'd like to make sure I didn't miss
anything related to some of the parts being build as modules for
example.

Thanks a lot,

Maxime

> Cheers,
> Nathan