Re: [PATCH net-next v5 4/6] net: gro: add {inner_}network_offset to napi_gro_cb

From: Richard Gobert
Date: Wed Apr 10 2024 - 09:00:56 EST


Willem de Bruijn wrote:
> Richard Gobert wrote:
>> This patch adds network_offset and inner_network_offset to napi_gro_cb, and
>> makes sure both are set correctly. In the common path there's only one
>> write (skb_gro_reset_offset).
>>
>> Signed-off-by: Richard Gobert <richardbgobert@xxxxxxxxx>
>> ---
>> include/net/gro.h | 18 ++++++++++++++++--
>> net/8021q/vlan_core.c | 2 ++
>> net/core/gro.c | 1 +
>> net/ethernet/eth.c | 1 +
>> net/ipv4/af_inet.c | 5 +----
>> net/ipv4/gre_offload.c | 1 +
>> net/ipv6/ip6_offload.c | 8 ++++----
>
> Should this cover more protocols, like geneve, ipsec?

Yes, my bad. It should be added to geneve, ipsec and vxlan too. I'll
double-check and post v6.