Re: [PATCH printk v4 10/27] printk: nbcon: Do not rely on proxy headers

From: Petr Mladek
Date: Wed Apr 10 2024 - 09:06:31 EST


On Wed 2024-04-03 00:17:12, John Ogness wrote:
> The headers kernel.h, serial_core.h, and console.h allow for the
> definitions of many types and functions from other headers.
> Rather than relying on these as proxy headers, explicitly
> include all headers providing needed definitions. Also sort the
> list alphabetically to be able to easily detect duplicates.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

Looks good. Well, I haven't really checked the list of includes one by
one, so I only provide:

Acked-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr