Re: [PATCH] fbdev/sh7760fb: allow modular build

[Helge Deller]

On 4/10/24 06:54, Randy Dunlap wrote:
> Hi,
>
> Will someone be merging this patch?

I've just added it to the fbdev git tree.

Thanks!
Helge


> thanks.
>
> On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote:
> > On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote:
> > > There is no reason to prohibit sh7760fb from being built as a
> > > loadable module as suggested by Geert, so change the config symbol
> > > from bool to tristate to allow that and change the FB dependency as
> > > needed.
> > >
> > > Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
> > > Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > > Cc: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> > > Cc: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > > Cc: Helge Deller <deller@xxxxxx>
> > > Cc: linux-fbdev@xxxxxxxxxxxxxxx
> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > ---
> > >   drivers/video/fbdev/Kconfig |    4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > > --- a/drivers/video/fbdev/Kconfig
> > > +++ b/drivers/video/fbdev/Kconfig
> > > @@ -1645,8 +1645,8 @@ config FB_COBALT
> > >   	select FB_IOMEM_HELPERS
> > >
> > >   config FB_SH7760
> > > -	bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
> > > -	depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
> > > +	tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
> > > +	depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
> > >   		|| CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
> > >   	select FB_IOMEM_HELPERS
> > >   	help
> >
> > Acked-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> >
> > Adrian