Re: [PATCH] soc: qcom: fix module autoloading

From: Bjorn Andersson
Date: Wed Apr 10 2024 - 14:11:47 EST


On Wed, Apr 10, 2024 at 07:53:32PM +0200, Konrad Dybcio wrote:
>
>
> On 4/10/24 18:40, Krzysztof Kozlowski wrote:
> > Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
> > based on the alias from of_device_id table.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > ---
>
> These were omitted intentionally, as these are both debug drivers.
>

Makes sense to me, could we have a comment added that clarifies this
intention?

> Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer
>

Not sure if that is necessary, and IMO it wouldn't convey that
MODULE_DEVICE_TABLE() was omitted intentionally.

Regards,
Bjorn