Re: [PATCH v3 4/9] spi: cadence-qspi: allow FIFO depth detection

From: Mark Brown
Date: Wed Apr 10 2024 - 16:03:32 EST


On Wed, Apr 10, 2024 at 11:29:07AM +0200, Théo Lebrun wrote:

> If FIFO depth DT property is provided, check it matches what hardware
> reports and warn otherwise. Else, use hardware provided value.
>
> Hardware exposes FIFO depth indirectly because
> CQSPI_REG_SRAMPARTITION is partially read-only.

This breaks an allmodconfig build:

/build/stage/linux/drivers/spi/spi-cadence-quadspi.c: In function ‘cqspi_of_get_
pdata’:
/build/stage/linux/drivers/spi/spi-cadence-quadspi.c:1506:45: error: unused vari
able ‘ddata’ [-Werror=unused-variable]
1506 | const struct cqspi_driver_platdata *ddata = cqspi->ddata;
| ^~~~~
/build/stage/linux/drivers/spi/spi-cadence-quadspi.c: In function ‘cqspi_control
ler_detect_fifo_depth’:
/build/stage/linux/drivers/spi/spi-cadence-quadspi.c:1582:45: error: unused vari
able ‘ddata’ [-Werror=unused-variable]
1582 | const struct cqspi_driver_platdata *ddata = cqspi->ddata;
| ^~~~~
cc1: all warnings being treated as errors

Attachment: signature.asc
Description: PGP signature