Re: [PATCH] hv: vmbus: Convert sprintf() family to sysfs_emit() family

From: Wei Liu
Date: Wed Apr 10 2024 - 17:25:36 EST


On Mon, Mar 25, 2024 at 05:49:47PM +0000, Wei Liu wrote:
> On Mon, Mar 25, 2024 at 09:39:52AM +0000, Zhijian Li (Fujitsu) wrote:
> >
> >
> > On 23/03/2024 07:37, Wei Liu wrote:
> > > Hi Zhijian,
> > >
> > > On Tue, Mar 19, 2024 at 11:43:50AM +0800, Li Zhijian wrote:
> > >> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> > >> or sysfs_emit_at() when formatting the value to be returned to user space.
> > >>
> > >> coccinelle complains that there are still a couple of functions that use
> > >> snprintf(). Convert them to sysfs_emit().
> > >>
> > >> sprintf() and scnprintf() will be converted as well if they have.
> > >
> > > This sentence seems to have been cut off halfway. If they have what?
> >
> > Is it hard to understand, what I want to say is:
> >
> > Sprintf() and scnprintf() will be converted if these files have such abused cases.
> >
> > Shall I update it and send a V2?
>
> No need. I can fix up the commit message when I apply the patch. Thanks.

Applied to hyperv-fixes. Thanks.