Re: [PATCH v2] selftests/timers/posix_timers: reimplement check_timer_distribution()

From: John Stultz
Date: Wed Apr 10 2024 - 18:33:37 EST


On Wed, Apr 10, 2024 at 3:31 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> On Wed, Apr 10 2024 at 15:21, John Stultz wrote:
> > On Tue, Apr 9, 2024 at 6:39 AM Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > This is working great here (on both 6.6 and the older 6.1)! Thanks so
> > much for fixing this!
> > One nit below, but otherwise:
> > Tested-by: John Stultz <jstultz@xxxxxxxxxx>
> >
> >> +err:
> >> + ksft_print_msg(errmsg);
> >
> > This bit is causing the following warning:
> > posix_timers.c:250:2: warning: format not a string literal and no
> > format arguments [-Wformat-security]
> > 250 | ksft_print_msg(errmsg);
> > | ^~~~~~~~~~~~~~
> >
> > A simple fix is just to switch it to:
> > ksft_print_msg("%s", errmsg);
>
> Can you please send a delta patch against tip timers/urgent?

Will do! Apologies for not getting to test and reply earlier.
-john