Re: [PATCH v6 05/10] block: Add core atomic write support

From: Luis Chamberlain
Date: Wed Apr 10 2024 - 19:34:45 EST


On Tue, Mar 26, 2024 at 10:11:50AM -0700, Randy Dunlap wrote:
> Hi,
>
> On 3/26/24 06:38, John Garry wrote:
> > diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
> > index 1fe9a553c37b..4c775f4bdefe 100644
> > --- a/Documentation/ABI/stable/sysfs-block
> > +++ b/Documentation/ABI/stable/sysfs-block
> > +What: /sys/block/<disk>/atomic_write_boundary_bytes
> > +Date: February 2024
> > +Contact: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> > +Description:
> > + [RO] A device may need to internally split I/Os which
> > + straddle a given logical block address boundary. In that
> > + case a single atomic write operation will be processed as
> > + one of more sub-operations which each complete atomically.
>
> or

If *or* was meant, wouldn't it be better just to say one or more
operations may be processed as one atomically in this situation?

Luis