Re: [PATCH net-next v2 4/4] net: dqs: make struct dql more cache efficient

From: Jakub Kicinski
Date: Wed Apr 10 2024 - 21:45:58 EST


On Wed, 10 Apr 2024 06:52:56 -0700 Breno Leitao wrote:
> > Doesn't this move the cache line bouncing problem to the other side?
>
> I think so. Looking at dql_check_stall(), it only uses fields in the
> second cache line, except now 'dql->stall_thrs' that is in the first
> cache line.

We do read num_queued at the beginning of dql_completed().
So maybe we we move the read of the threshold there we will be fine.