Re: [PATCH] platform/chrome: cros_ec_uart: properly fix race condition

From: Guenter Roeck
Date: Wed Apr 10 2024 - 22:26:29 EST


On Wed, Apr 10, 2024 at 7:18 PM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
>
> On Thu, Apr 11, 2024 at 12:06:33AM +0200, Noah Loomans wrote:
> > On 2024-04-10 at 21:48 UTC+02, Guenter Roeck wrote:
> > > On Wed, Apr 10, 2024 at 11:29 AM Noah Loomans <noah@xxxxxxxxxxxxxxx> wrote:
> > > > This is my first time contributing to Linux, I hope this is a good
> > > > patch. Feedback on how to improve is welcome!
> > >
> > > The commit message is a bit long, but the patch itself looks good to me.
> >
> > Hmm yeah it's a bit on a long side. I'm not sure what could be removed
> > though, it all seems relevant for understanding the bug and the fix.
>
> Applied with shortening the message slightly.

We might also consider applying the patch to all ChromeOS branches
directly (not waiting for upstream); we do see a number of crashes
because of it.

Guenter