Re: [PATCH v2 1/1] media: v4l: Don't turn on privacy LED if streamon fails

[Umang Jain]

Hi Sakari,

Thank you for the patch

On 10/04/24 5:18 pm, Hans de Goede wrote:
> Hi,
>
> On 4/10/24 1:47 PM, Sakari Ailus wrote:
> > Turn on the privacy LED only if streamon succeeds. This can be done after
> > enabling streaming on the sensor.
> >
> > Fixes: b6e10ff6c23d ("media: v4l2-core: Make the v4l2-core code enable/disable the privacy LED if present")
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Thanks, patch looks good to me:

Looks good to me too
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Reviewed-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>

> Regards,
>
> Hans
>
>
>
> > ---
> >   drivers/media/v4l2-core/v4l2-subdev.c | 22 ++++++++++++----------
> >   1 file changed, 12 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> > index 4c6198c48dd6..012b757eac9f 100644
> > --- a/drivers/media/v4l2-core/v4l2-subdev.c
> > +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> > @@ -412,15 +412,6 @@ static int call_s_stream(struct v4l2_subdev *sd, int enable)
> >   	if (WARN_ON(!!sd->enabled_streams == !!enable))
> >   		return 0;
> >   
> > -#if IS_REACHABLE(CONFIG_LEDS_CLASS)
> > -	if (!IS_ERR_OR_NULL(sd->privacy_led)) {
> > -		if (enable)
> > -			led_set_brightness(sd->privacy_led,
> > -					   sd->privacy_led->max_brightness);
> > -		else
> > -			led_set_brightness(sd->privacy_led, 0);
> > -	}
> > -#endif
> >   	ret = sd->ops->video->s_stream(sd, enable);
> >   
> >   	if (!enable && ret < 0) {
> > @@ -428,9 +419,20 @@ static int call_s_stream(struct v4l2_subdev *sd, int enable)
> >   		ret = 0;
> >   	}
> >   
> > -	if (!ret)
> > +	if (!ret) {
> >   		sd->enabled_streams = enable ? BIT(0) : 0;
> >   
> > +#if IS_REACHABLE(CONFIG_LEDS_CLASS)
> > +		if (!IS_ERR_OR_NULL(sd->privacy_led)) {
> > +			if (enable)
> > +				led_set_brightness(sd->privacy_led,
> > +						   sd->privacy_led->max_brightness);
> > +			else
> > +				led_set_brightness(sd->privacy_led, 0);
> > +		}
> > +#endif
> > +	}
> > +
> >   	return ret;
> >   }
> >