Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

[Krzysztof Kozlowski]

On 11/04/2024 05:37, olivia.wen wrote:
> Under different applications, the MT8188 SCP can be used as single-core
> or dual-core.
> 
> Signed-off-by: olivia.wen <olivia.wen@xxxxxxxxxxxx>

Are you sure you use full name, not email login as name?

> ---
>  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> index 507f98f..7e7b567 100644
> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> @@ -22,7 +22,7 @@ properties:
>        - mediatek,mt8192-scp
>        - mediatek,mt8195-scp
>        - mediatek,mt8195-scp-dual
> -
> +      - mediatek,mt8188-scp-dual

Missing blank line, misordered.


>    reg:
>      description:
>        Should contain the address ranges for memory regions SRAM, CFG, and,
> @@ -195,6 +195,7 @@ allOf:
>          compatible:
>            enum:
>              - mediatek,mt8195-scp-dual
> +            - mediatek,mt8188-scp-dual

Again, keep the order.



Best regards,
Krzysztof