Re: [PATCH v3 6/6] thermal: core: Relocate critical and hot trip handling

[Lukasz Luba]

On 4/10/24 16:56, Rafael J. Wysocki wrote:
> Hi Lukasz,
>
> On Fri, Apr 5, 2024 at 9:35 AM Lukasz Luba <lukasz.luba@xxxxxxx> wrote:
> > Hi Rafael,
> >
> > On 4/4/24 10:03, Rafael J. Wysocki wrote:
> > > On Tue, Apr 2, 2024 at 9:04 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
> > > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > > >
> > > > Modify handle_thermal_trip() to call handle_critical_trips() only after
> > > > finding that the trip temperature has been crossed on the way up and
> > > > remove the redundant temperature check from the latter.
> > > >
> > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > >
> > > This change is premature, as it will cause handle_non_critical_trips()
> > > to be called for hot/critical trips which is questionable, so I'm
> > > withdrawing it for now.
> > >
> > > The rest of the series is still applicable, though.
> >
> > Could you explain your concerns about this, please?
> > Is about the extra execution time for the non-critical trip,
> > while we are in section of handling critical ASAP?
> > (also it would require that extra sorting there IMO)
>
> No, it is mostly about exposing the critical and hot trips to the
> governor code that may not be ready for seeing them and get somewhat
> surprised.  In particular, this would cause the User Space governor to
> send uevents regarding critical and hot trip points which it has not
> been doing so far and so user space may get confused.

Got it, thanks!