Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

[AngeloGioacchino Del Regno]

Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto:
> Il 11/04/24 05:37, olivia.wen ha scritto:
> > Under different applications, the MT8188 SCP can be used as single-core
> > or dual-core.
> >
> > Signed-off-by: olivia.wen <olivia.wen@xxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml 
> > b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > index 507f98f..7e7b567 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > @@ -22,7 +22,7 @@ properties:
> >         - mediatek,mt8192-scp
> >         - mediatek,mt8195-scp
> >         - mediatek,mt8195-scp-dual
> > -
>
> Don't remove the blank line, it's there for readability.
>
> > +      - mediatek,mt8188-scp-dual

Ah, sorry, one more comment. Please, keep the entries ordered by name.
8188 goes before 8195.

> After addressing that comment,
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
>
> >     reg:
> >       description:
> >         Should contain the address ranges for memory regions SRAM, CFG, and,
> > @@ -195,6 +195,7 @@ allOf:
> >           compatible:
> >             enum:
> >               - mediatek,mt8195-scp-dual
> > +            - mediatek,mt8188-scp-dual

same here.

> >       then:
> >         properties:
> >           reg: