Re: [PATCH v1 1/1] auxdisplay: charlcd: Don't rebuild when CONFIG_PANEL_BOOT_MESSAGE=y

[Geert Uytterhoeven]

Hi Andy,

On Tue, Apr 9, 2024 at 7:39 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> When CONFIG_PANEL_BOOT_MESSAGE=y the module still includes
> the generated header and gets rebuilt even if it doesn't use
> anything from that header.  Include generated header conditionally
> to avoid unnecessary rebuilds.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/auxdisplay/charlcd.c
> +++ b/drivers/auxdisplay/charlcd.c
> @@ -17,7 +17,9 @@
>  #include <linux/uaccess.h>
>  #include <linux/workqueue.h>
>
> +#ifndef CONFIG_PANEL_BOOT_MESSAGE
>  #include <generated/utsrelease.h>
> +#endif

Perhaps move the existing "#ifdef CONFIG_PANEL_BOOT_MESSAGE"-block
up, and move the #include inside the #else branch?

>
>  #include "charlcd.h"

Regardless
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds