Re: [PATCH] x86/smpboot: Add map vars allocation check in smp_prepare_cpus_common

From: Ingo Molnar
Date: Thu Apr 11 2024 - 04:43:31 EST



* Nikita Kiryushin <kiryushin@xxxxxxxx> wrote:

> But I have some questions considering __GFP_NOFAIL. It clearly shows,
> that allocation will not fail/is not expected to fail, does it not try
> making allocation until it succeeds? Would not it make the system hang in
> a problematic case?

Yes, which is better than undefined behavior. This case should only happen
on hopelessly buggy kernels or hopelessly buggy hardware - which will very
likely crash way sooner before they get into this part of the init
sequence.

This whole problem is a non-issue.

Thanks,

Ingo