Re: [PATCH v5 0/2] Samsung Galaxy Z Fold5 initial support

[Krzysztof Kozlowski]

On 11/04/2024 09:34, Krzysztof Kozlowski wrote:
> On 11/04/2024 08:36, Alexandru Serdeliuc wrote:
>> Hi,
>>
>> The list of changes  (changelog) from the cover is not what I should  add?
>>
>> My patches received only two ACK tags, on V3 and on the initial request 
>> (v1), I was not able to identify any other, I added them to their place 
>> in the change log
>>
>> ...
>> - v3
>>    . added b4 version 3
>>    . removed address and size cells in device description
>>    Acked-by: Rob Herring<robh@xxxxxxxxxx>
>> ...
>> - v1
>>    . The initial request was split in two patches sent due to the following checkpatch warning, was requested to re send them together:
>>      WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>>    Acked-by: Krzysztof Kozlowski<krzysztof.kozlowski@xxxxxxxxxx>
>>
>> I suppose that adding them to their place in change log is wrong, I 
>> should create a v6 and put them at the end of the cover letter? Or how 
>> to proceed?
> 
> Please don't top post. If you add them to the changelog, how are they
> going to be effective? Please apply your patch (e.g. b4 shazam) and look
> for them...
> 
> Submitting patches explains where to add tags. Look at other mailings.
> And finally: why even bothering about this if b4 does it for you?
> 

BTW, in reply to your first posting I gave you detailed instruction how
to proceed with tags. Let me quote:

"Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag"

I think it is clear where you should add it. I gave this instruction on
purpose so we will avoid this mess...

Drop all invalid acks from cover letter and send v6 with proper tags
places in mentioned place.

Best regards,
Krzysztof