RE: [PATCH 1/2 v4] dt-bindings: pwm: Add AXI PWM generator

[Hennerich, Michael]

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Sent: Thursday, April 11, 2024 12:33 PM
> To: Trevor Gamblin <tgamblin@xxxxxxxxxxxx>
> Cc: linux-pwm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Hennerich,
> Michael <Michael.Hennerich@xxxxxxxxxx>; Sa, Nuno
> <Nuno.Sa@xxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; David Lechner
> <dlechner@xxxxxxxxxxxx>; Drew Fustini <dfustini@xxxxxxxxxxxx>; Krzysztof
> Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: Re: [PATCH 1/2 v4] dt-bindings: pwm: Add AXI PWM generator
> 
> 
> Hello,
> 
> On Fri, Mar 01, 2024 at 12:33:41PM -0500, Trevor Gamblin wrote:
> > From: Drew Fustini <dfustini@xxxxxxxxxxxx>
> >
> > Add Analog Devices AXI PWM generator.
> >
> > Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> > Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Co-developed-by: Trevor Gamblin <tgamblin@xxxxxxxxxxxx>
> > Signed-off-by: Trevor Gamblin <tgamblin@xxxxxxxxxxxx>
> > ---
> > v4 changes: None (rebased, added maintainer's previous Reviewed-by)
> > v3 changes: None (rebased, added maintainer's previous Reviewed-by)
> >
> > v2 changes:
> > * Address feedback for driver and device tree in v1:
> >   * Relocate "unevaluatedProperties" in device tree binding
> >   * Remove redundant "bindings for" in description
> >
> > ---
> >  .../bindings/pwm/adi,axi-pwmgen.yaml          | 48 +++++++++++++++++++
> >  MAINTAINERS                                   |  8 ++++
> >  2 files changed, 56 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> > b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> > new file mode 100644
> > index 000000000000..63461920a362
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> > @@ -0,0 +1,48 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AXI PWM generator
> > +
> > +maintainers:
> > +  - Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
> > +  - Nuno Sá <nuno.sa@xxxxxxxxxx>
> 
> Would be great to get an ack from these two.

Looks good to me.

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> Otherwise looks fine to me.
> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |