Re: [PATCH v8 0/3] clk: qcom: clk-rcg2: introduce support for multiple conf for same freq

[Kathiravan Thirumoorthy]

On 4/11/2024 10:31 AM, Stephen Boyd wrote:
> Quoting Kathiravan Thirumoorthy (2024-01-22 09:46:23)
> > On 12/21/2023 3:47 AM, Christian Marangi wrote:
> > > This small series fix a current problem with ipq8074 where the 2 uniphy
> > > port doesn't work in some corner case with some clk configuration. The
> > > port to correctly work require a specific frequency, using the wrong one
> > > results in the port not transmitting data.
> > >
> > > With the current code with a requested freq of 125MHz, the frequency is
> > > set to 105MHz. This is caused by the fact that there are 2 different
> > > configuration to set 125MHz and it's always selected the first one that
> > > results in 105MHz.
> > >
> > > In the original QSDK code, the frequency configuration selection is
> > > different and the CEIL FLOOR logic is not present. Instead it's used a
> > > BEST approach where the frequency table is checked and then it's checked
> > > if there are duplicate entry.
> > >
> > > This proposed implementation is more specific and introduce an entire new
> > > set of ops and a specific freq table to support this special configuration.
> > >
> > > A union is introduced in rcg2 struct to not duplicate the struct.
> > > A new set of ops clk_rcg2_fm_ops are introduced to support this new kind
> > > of frequency table.
> >
> >
> > Bjorn / Stephen Boyd,
> >
> > I would like to know if there are any comments on this series. To enable
> > the clocks required for the Ethernet interfaces on the IPQ platforms,
> > these patches are needed. If no concerns, can this be picked up for v6.9?
>
> I'm fine if Bjorn wants to pick it up.
>
> Acked-by: Stephen Boyd <sboyd@xxxxxxxxxx>


Thanks Stephen. Bjorn, can this series picked up for v6.10, if no 
concerns from your side?

Thanks,
Kathiravan.