Re: [PATCH net-next] flow_offload: fix flow_offload_has_one_action() kdoc

From: Pieter Jansen van Vuuren
Date: Thu Apr 11 2024 - 07:33:11 EST


[Removed my old email address from CC]

This LGTM, thank you.

Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@xxxxxxx>

On 10/04/2024 12:47, Asbjørn Sloth Tønnesen wrote:
> include/net/flow_offload.h:351: warning:
> No description found for return value of 'flow_offload_has_one_action'
>
> Fixes: ab79af32b0a5 ("mlxsw: use intermediate representation for matchall offload")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>
> ---
> include/net/flow_offload.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 314087a5e1818..7726b4a97050e 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -345,7 +345,7 @@ static inline bool flow_action_has_entries(const struct flow_action *action)
> * flow_offload_has_one_action() - check if exactly one action is present
> * @action: tc filter flow offload action
> *
> - * Returns true if exactly one action is present.
> + * Return: true if exactly one action is present.
> */
> static inline bool flow_offload_has_one_action(const struct flow_action *action)
> {