Re: [PATCH 2/2] locking/pvqspinlock: Use try_cmpxchg() in qspinlock_paravirt.h

From: Ingo Molnar
Date: Thu Apr 11 2024 - 09:24:41 EST



* Uros Bizjak <ubizjak@xxxxxxxxx> wrote:

> - locked = cmpxchg_release(&lock->locked, _Q_LOCKED_VAL, 0);
> - if (likely(locked == _Q_LOCKED_VAL))
> + if (try_cmpxchg_release(&lock->locked, &locked, 0);
> return; ^------------ ???

This doesn't appear to be a particularly well-tested patch. ;-)

Thanks,

Ingo