Re: [PATCH net-next] gve: Correctly report software timestamping capabilities

[John Fraker]

On Wed, Apr 10, 2024 at 8:22 PM Willem de Bruijn
<willemdebruijn.kernel@xxxxxxxxx> wrote:
>
> Jakub Kicinski wrote:
> > On Mon,  8 Apr 2024 11:09:01 -0700 John Fraker wrote:
> > > gve has supported software timestamp generation since its inception,
> > > but has not advertised that support via ethtool. This patch correctly
> > > advertises that support.
> > >
> > > Reviewed-by: Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>
> > > Reviewed-by: Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>
> > > Signed-off-by: John Fraker <jfraker@xxxxxxxxxx>
> >
> > I think it should be a single line diff:
> >
> > +     .get_ts_info = ethtool_op_get_ts_info,
> >
> > right?
>
> If inserted above .get_link_ksettings that works. The current
> ordering is not based on actual struct layout anyway.
>
> Probably all statements should just end in a comma, including a
> trailing comma. To avoid these two line changes on each subsequent
> change.

Thanks all!

I'll send the one-line v2.

> The rest of the discussion in this thread is actually quite
> unrelated to this patch. Didn't meant to sidetrack that.