RE: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible stringg

[Joy Zou]

> -----Original Message-----
> From: Frank Li <frank.li@xxxxxxx>
> Sent: 2024年4月11日 21:21
> To: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Joy Zou <joy.zou@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>;
> vkoul@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; imx@xxxxxxxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused
> "fsl,imx8qm-adma" compatible stringg
> 
> 
> It should be
> 
> dt-bindings: fsl-dma: fsl-edma: clean up unused "fsl,imx8qm-adma"
> compatible stringg
> 
> 
> b7b8715b430ee dt-bindings: fsl-dma: fsl-edma: add fsl,imx95-edma5
> compatible string 6eb439dff645a dt-bindings: fsl-dma: fsl-edma: add edma3
> compatible string
> 10cafa2d45885 dt-bindings: dma: drop unneeded quotes cfa1927f8468c
> dt-bindings: dma: fsl-edma: Convert to DT schema
> 
> 
> On Thu, Apr 11, 2024 at 10:13:38AM +0200, Krzysztof Kozlowski wrote:
> > On 11/04/2024 09:43, Joy Zou wrote:
> > > The compatible string "fsl,imx8qm-adma" is unused.
> >
> > Why? Commit must stand on its own.
> 
> Joy:
> 	You can copy patch2's comit
Thanks your comments!
Will add more description for the drop reason.
> >
> > >
> > > Signed-off-by: Joy Zou <joy.zou@xxxxxxx>
> > > ---
> >
> > Please use subject prefixes matching the subsystem. You can get them
> > for example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> > directory your patch is touching.
> >
> > >  Documentation/devicetree/bindings/dma/fsl,edma.yaml | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > > b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > > index 825f4715499e..64fa27d0cd9b 100644
> > > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > > @@ -21,7 +21,6 @@ properties:
> > >        - enum:
> > >            - fsl,vf610-edma
> > >            - fsl,imx7ulp-edma
> > > -          - fsl,imx8qm-adma
> >
> >
> > I see more usages. One more trivial patch which is incorrect.
> >
> 
> Please clean up AllOf also.
> 
> allOf:
>   - $ref: dma-controller.yaml#
>   - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - fsl,imx8qm-adma
>                            ^^^^
>               - fsl,imx8qm-edma
> 
Yeah, will clean up also.
BR
Joy Zou
> > Did you implement the internal review?
> 
> Patch2 was internal reviewed. Patch1 is new. I know you are busy. Could you
> please give me 1 days to review nxp's patches. You see patch always ahead
> me if author and you are in similar time zone.
> 
> I knew they are quite busy on heavy development work and all kinds
> customer supports.
> 
> Frank
> 
> > Best regards,
> > Krzysztof
> >