Re: [PATCH] sysrq: Auto release device node using __free attribute

From: Greg KH
Date: Fri Apr 12 2024 - 01:21:08 EST



A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Apr 11, 2024 at 08:28:17PM +0200, Roman Storozhenko wrote:
> This change allows us to put this pointer under automatic scope
> management and get rid of node_put. Besides, if a new code path is
> introduced we won't need to add a new of_node_put.

We worry about future stuff then, in the future. So no need for
changing code today for things that are not present at all, otherwise
you would never be finished with anything, right?

Don't make things more complex when it is not needed. Only add
complexity when it is needed.

thanks,

greg k-h