[PATCH v2] bcachefs: fix error path of __bch2_read_super()

From: Chao Yu
Date: Fri Apr 12 2024 - 02:37:06 EST


In __bch2_read_super(), if kstrdup() fails, it needs to release memory
in sb->holder, fix to call bch2_free_super() in the error path.

Signed-off-by: Chao Yu <chao@xxxxxxxxxx>
---
v2:
- add error message in error path pointed out by Hongbo Li.
fs/bcachefs/super-io.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/bcachefs/super-io.c b/fs/bcachefs/super-io.c
index ad28e370b640..cc80d7d30b8c 100644
--- a/fs/bcachefs/super-io.c
+++ b/fs/bcachefs/super-io.c
@@ -698,8 +698,11 @@ static int __bch2_read_super(const char *path, struct bch_opts *opts,
return -ENOMEM;

sb->sb_name = kstrdup(path, GFP_KERNEL);
- if (!sb->sb_name)
- return -ENOMEM;
+ if (!sb->sb_name) {
+ ret = -ENOMEM;
+ prt_printf(&err, "error allocating memory for sb_name");
+ goto err;
+ }

#ifndef __KERNEL__
if (opt_get(*opts, direct_io) == false)
--
2.40.1