Re: [PATCH V7 net-next 4/4] net: hns3: add support to query scc version by devlink info

[Jijie Shao]

on 2024/4/11 14:23, Jiri Pirko wrote:
> Thu, Apr 11, 2024 at 03:05:53AM CEST, shaojijie@xxxxxxxxxx wrote:
> > on 2024/4/10 22:59, Jiri Pirko wrote:
> > > Wed, Apr 10, 2024 at 02:53:54PM CEST, shaojijie@xxxxxxxxxx wrote:
> > > > From: Hao Chen <chenhao418@xxxxxxxxxx>
> > > >
> > > > Add support to query scc version by devlink info for device V3.
> > > >
> > > > Signed-off-by: Hao Chen <chenhao418@xxxxxxxxxx>
> > > > Signed-off-by: Jijie Shao <shaojijie@xxxxxxxxxx>
> > > > ---
> > > > Documentation/networking/devlink/hns3.rst     |  3 ++
> > > > drivers/net/ethernet/hisilicon/hns3/hnae3.h   |  9 ++++
> > > > .../hns3/hns3_common/hclge_comm_cmd.h         |  8 ++++
> > > > .../hisilicon/hns3/hns3pf/hclge_devlink.c     | 44 +++++++++++++++++--
> > > > .../hisilicon/hns3/hns3pf/hclge_devlink.h     |  2 +
> > > > .../hisilicon/hns3/hns3pf/hclge_main.c        | 18 ++++++++
> > > > .../hisilicon/hns3/hns3pf/hclge_main.h        |  1 +
> > > > 7 files changed, 82 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/Documentation/networking/devlink/hns3.rst b/Documentation/networking/devlink/hns3.rst
> > > > index 4562a6e4782f..e19dea8ef924 100644
> > > > --- a/Documentation/networking/devlink/hns3.rst
> > > > +++ b/Documentation/networking/devlink/hns3.rst
> > > > @@ -23,3 +23,6 @@ The ``hns3`` driver reports the following versions
> > > >      * - ``fw``
> > > >        - running
> > > >        - Used to represent the firmware version.
> > > > +   * - ``fw.scc``
> > > What's scc? I don't see it described anywhere.
> > diff --git a/Documentation/networking/devlink/hns3.rst b/Documentation/networking/devlink/hns3.rst
> > index 4562a6e4782f..e19dea8ef924 100644
> > --- a/Documentation/networking/devlink/hns3.rst
> > +++ b/Documentation/networking/devlink/hns3.rst
> > @@ -23,3 +23,6 @@ The ``hns3`` driver reports the following versions
> >     * - ``fw``
> >       - running
> >       - Used to represent the firmware version.
> > +   * - ``fw.scc``
> > +     - running
> > +     - Used to represent the soft congestion control firmware version.
> >
> > scc means "soft congestion control"
> I guess this is something specific to your device, isn't it? Can't you
> please extend the description a bit more?
>
> Thanks!
SCC is a firmware which provides multiple congestion control algorithms, including dcqcn.
Congestion control is a mechanism that controls the entry of rdma packets into the network,
enabling a better use of a shared network infrastructure and avoiding congestive collapse.


Jijie Shao