Re: [PATCH 4/5] Kconfig: Enable APM X-Gene RTC for XuanTie TH1520

From: Conor Dooley
Date: Fri Apr 12 2024 - 05:49:35 EST


On Fri, Apr 12, 2024 at 04:01:46PM +0800, wefu@xxxxxxxxxx wrote:
> From: Wei Fu <wefu@xxxxxxxxxx>
>
> This patch enables APM X-Gene RTC for XuanTie TH1520.
>
> Signed-off-by: Wei Fu <wefu@xxxxxxxxxx>
> ---
> drivers/rtc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 3a89f1e6095d..b219aeef4ce9 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1880,7 +1880,7 @@ config RTC_DRV_MT7622
> config RTC_DRV_XGENE
> tristate "APM X-Gene RTC"
> depends on HAS_IOMEM
> - depends on ARCH_XGENE || COMPILE_TEST
> + depends on ARCH_XGENE || ARCH_THEAD || COMPILE_TEST
> help
> If you say yes here you get support for the APM X-Gene SoC real time
> clock.

If I was configuring my system by reading menuconfig, I would have
absolutely no idea that this driver supports platforms other than the
X-Gene one. I think the Kconfig stuff for this likely needs an update to
convey that it's no longer just one SoC family that's supported here.

Attachment: signature.asc
Description: PGP signature