Re: [PATCH net] octeontx2-pf: fix FLOW_DIS_IS_FRAGMENT implementation

[Asbjørn Sloth Tønnesen]

Hi again,

On 4/12/24 9:01 AM, Asbjørn Sloth Tønnesen wrote:
> There are therefore 3 possible cases:
>
> - `tc flower ...` (no ip_flags frag or nofrag)
>     (match.key->flags & FLOW_DIS_FIRST_FRAG)  is false
>     (match.mask->flags & FLOW_DIS_FIRST_FRAG) is false
>
> - `tc flower ... ip_flags nofrag`
>     (match.key->flags & FLOW_DIS_FIRST_FRAG)  is false
>     (match.mask->flags & FLOW_DIS_FIRST_FRAG) is true
>
> - `tc flower ... ip_flags frag`
>     (match.key->flags & FLOW_DIS_FIRST_FRAG)  is true
>     (match.mask->flags & FLOW_DIS_FIRST_FRAG) is true

I was a bit a hurry, to get the reply in before a meeting,
so: s/FLOW_DIS_FIRST_FRAG/FLOW_DIS_IS_FRAGMENT/g

There are therefore 3 possible cases:

- `tc flower ...` (no ip_flags frag or nofrag)
   (match.key->flags & FLOW_DIS_IS_FRAGMENT)  is false
   (match.mask->flags & FLOW_DIS_IS_FRAGMENT) is false

- `tc flower ... ip_flags nofrag`
   (match.key->flags & FLOW_DIS_IS_FRAGMENT)  is false
   (match.mask->flags & FLOW_DIS_IS_FRAGMENT) is true

- `tc flower ... ip_flags frag`
   (match.key->flags & FLOW_DIS_IS_FRAGMENT)  is true
   (match.mask->flags & FLOW_DIS_IS_FRAGMENT) is true

--
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541