Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

[Olivia Wen (温倩苓)]

Hi Krzysztof,

On Thu, 2024-04-11 at 08:07 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 11/04/2024 05:37, olivia.wen wrote:
> > +};
> > +
> >  static const struct of_device_id mtk_scp_of_match[] = {
> >  { .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data },
> >  { .compatible = "mediatek,mt8186-scp", .data = &mt8186_of_data },
> > @@ -1323,6 +1362,7 @@ static const struct of_device_id
> mtk_scp_of_match[] = {
> >  { .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data },
> >  { .compatible = "mediatek,mt8195-scp", .data = &mt8195_of_data },
> >  { .compatible = "mediatek,mt8195-scp-dual", .data =
> &mt8195_of_data_cores },
> > +{ .compatible = "mediatek,mt8188-scp-dual", .data =
> &mt8188_of_data_cores },
> 
> Why do you add new entries to the end? Look at the list first.
> 
> Best regards,
> Krzysztof

Thanks for the reviews.
I will change the order as follows.
> +{ .compatible = "mediatek,mt8188-scp-dual", .data =
&mt8188_of_data_cores },
>  { .compatible = "mediatek,mt8195-scp-dual", .data =
&mt8195_of_data_cores },

Best regards,
Olivia