Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page

From: Matthew Wilcox
Date: Fri Apr 12 2024 - 10:18:32 EST


On Fri, Apr 12, 2024 at 10:14:39PM +0800, Haifeng Xu wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index e7bf1a1a31a8..49a3ebefab86 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4461,9 +4461,7 @@ static int calculate_sizes(struct kmem_cache *s)
> if ((int)order < 0)
> return 0;
>
> - s->allocflags = 0;
> - if (order)
> - s->allocflags |= __GFP_COMP;
> + s->allocflags = __GFP_COMP;
>
> if (s->flags & SLAB_CACHE_DMA)
> s->allocflags |= GFP_DMA;

Resend this with a proper changelog and you can add:

Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>