Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels

From: Andy Shevchenko
Date: Fri Apr 12 2024 - 12:46:04 EST


On Fri, Apr 12, 2024 at 07:15:11PM +0300, Raag Jadav wrote:
> On Fri, Apr 12, 2024 at 06:35:51PM +0300, Andy Shevchenko wrote:
> > On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:

..

> > > + data = devm_kzalloc(dev, struct_size(data, chips, info->nr), GFP_KERNEL);
> > > + if (!data)
> > > + return dev_err_probe(dev, -ENOMEM, "Failed to allocate drvdata\n");
> >
> > Haven't noticed before, but we do not print messages for -ENOMEM. Just return
> > the code.
>
> Any special case for -ENOMEM?

Yes. But I have no link to the discussion at hand. Just believe me, or look into
Git history for changes that drop that messaging. Perhaps one or two will give a
hint where it starts from...

> I found a few drivers which still do.

They should be fixed.

--
With Best Regards,
Andy Shevchenko