Re: [PATCH] driver core: Make dev_err_probe() silent for -ENOMEM

[Uwe Kleine-König]

Hello Andy,

On Fri, Apr 12, 2024 at 07:51:48PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 06:44:05PM +0200, Uwe Kleine-König wrote:
> > For an out-of-memory error there should be no additional output. Adapt
> > dev_err_probe() to not emit the error message when err is -ENOMEM.
> > This simplifies handling errors that might among others be -ENOMEM.
> 
> ...
> 
> 	BUILD_BUG_ON(err == -ENOMEM);
> 
> Done!

Well no, that doesn't do the trick. Consider for example device_add().
That function can return (at least) -EINVAL and -ENOMEM. To properly
ensure that the error handling is silent with the current
dev_err_probe(), we'd need to do:

	ret = device_add(...);
	if (ret) {
		if (ret != -ENOMEM)
			return dev_err_probe(...);
		else
			return ret;
	}

With my suggested patch this can be reduced to:

	ret = device_add(...);
	if (ret)
		return dev_err_probe(...);

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature