Re: [PATCH v5 01/18] cpu: Do not warn on arch_register_cpu() returning -EPROBE_DEFER

From: Rafael J. Wysocki
Date: Fri Apr 12 2024 - 13:42:43 EST


On Fri, Apr 12, 2024 at 4:37 PM Jonathan Cameron
<Jonathan.Cameron@xxxxxxxxxx> wrote:
>
> For arm64 the CPU registration cannot complete until the ACPI intepretter
> us up and running so in those cases the arch specific
> arch_register_cpu() will return -EPROBE_DEFER at this stage and the
> registration will be attempted later.
>
> Suggested-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Acked-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>

> ---
> v5: New patch.
> Note that for now no arch_register_cpu() calls return -EPROBE_DEFER
> so it has no impact until the arm64 one is added later in this series.
> ---
> drivers/base/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
> index 56fba44ba391..b9d0d14e5960 100644
> --- a/drivers/base/cpu.c
> +++ b/drivers/base/cpu.c
> @@ -558,7 +558,7 @@ static void __init cpu_dev_register_generic(void)
>
> for_each_present_cpu(i) {
> ret = arch_register_cpu(i);
> - if (ret)
> + if (ret != -EPROBE_DEFER)
> pr_warn("register_cpu %d failed (%d)\n", i, ret);
> }
> }
> --
> 2.39.2
>