Re: *** SPAM *** Re: [PATCH 4.19 000/175] 4.19.312-rc1 review

From: Marion & Christophe JAILLET
Date: Fri Apr 12 2024 - 16:15:38 EST



Le 12/04/2024 à 21:46, Pavel Machek a écrit :
Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
slimbus: core: Remove usage of the deprecated ida_simple_xx() API
AFAICT this is just a cleanup. We should not need this.

Not exactly.

As stated in the commit: "this change allows one more device. Previously address 0xFE was never used."

I don't use slimbus, so I'll let people with more knowledge than me about this driver decide if it should be backported or not, but from my point of view, it is a valid fix.

But, unless s.o. complained that this extra device address was needed in a RL scenario, I would say that the patch should not be backported, because: "better safe than sorry".

CJ