Re: [PATCH 7/7] scripts/faddr2line: Check only two symbols when calculating symbol size

[Josh Poimboeuf]

On Thu, Apr 11, 2024 at 12:28:29PM -0700, Brian Johannesmeyer wrote:
> Hey Josh,
> 
> I just noticed that this patch does not correctly handle duplicate
> sym_names. To fix, the "--no-group-separator" option should be added
> as follows:
> 
> > -               done < <(echo "${ELF_SYMS}" | sed 's/\[.*\]//' | ${AWK} -v sec=$sym_sec '$7 == sec' | sort --key=2)
> > +               done < <(echo "${ELF_SYMS}" | sed 's/\[.*\]//' | ${AWK} -v sec=$sym_sec '$7 == sec' | sort --key=2 | ${GREP} -A1 --no-group-separator " ${sym_name}$")
> 
> Would you like me to re-submit the patch series with this fix?

Yes, that would be helpful.  Thanks!

-- 
Josh